fix(voice): keep realtime turn after chat ctx timeout#2083
Open
rosetta-livekit-bot[bot] wants to merge 4 commits into
Open
fix(voice): keep realtime turn after chat ctx timeout#2083rosetta-livekit-bot[bot] wants to merge 4 commits into
rosetta-livekit-bot[bot] wants to merge 4 commits into
Conversation
🦋 Changeset detectedLatest commit: 4be6aae The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Add TypeDoc for RealtimeError and SpeechHandle.exception, and reject RunResult when the last SpeechHandle completed with an error so session.run() matches Python SpeechHandle._error propagation. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports Python PR #4972 (
fix(realtime): report errors to SpeechHandle when update_chat_ctx fails) to Node.js.When OpenAI Realtime
updateChatCtxtimes out (or otherwise throwsRealtimeError), AgentActivity now:SpeechHandlewith that error viaSpeechHandle._markExceptionErrorEventso the session can surface itsession.run()/RunResultrejects with that error (Python_errorparity) instead of returning a successful empty runAlso documents the public
RealtimeErrorandSpeechHandle.exception()APIs for TypeDoc.Follow-up fixes (post Rosetta review)
RealtimeErrorandSpeechHandle.exception()RunResult._markDonenow rejects whenSpeechHandle.exception()is set (Pythonsession.run()/_errorparity)speech_handle.test.tsandrun_result.test.tsmainafter CI flake on LiveKit inference (4be6aaef)Cue verification
sid_015f53d04968(OpenAI Realtime temporary worker)~/.cue-cli/sessions/sid_015f53d04968/Test plan
verified-portadded